Conversation
|
I thought of a couple of improvements overnight, just trying to tidy this up with clearer function names and inheritance, so converted to draft. |
…clearer function names, and the three classes used provide minimal intefaces and clearer documentation.
|
Ready for review again. Hopefully clearer. |
…are meant for external use.
|
Thanks @thompson318 - I should have time to review this tomorrow 👍 |
K-Meech
left a comment
K-Meech
left a comment
There was a problem hiding this comment.
Thanks @thompson318 - great to have everything under the MIT license again! 😄
I've put some comments below. The main one is that I think you might need to separate the speed / data steady logic into separate classes. At the moment they can be called with incompatible data due to the differences in what GetData returns.
… or min data requirement.
|
@K-Meech I think I've addressed all your comments now so ready for another review please. |
K-Meech
left a comment
K-Meech
left a comment
There was a problem hiding this comment.
Thanks @thompson318 - looks good! Couple of very minor comments below.
Co-authored-by: Kimberly Meechan <24316371+K-Meech@users.noreply.github.com>
Co-authored-by: Kimberly Meechan <24316371+K-Meech@users.noreply.github.com>
Co-authored-by: Kimberly Meechan <24316371+K-Meech@users.noreply.github.com>
2 participants
This addresses #44, allowing us to return to MIT License.
It implements a bare minimum replacement for the functionality we used in RingBuffer.cs (which was very little) then derived classes for gaze, pitch, and yaw.